From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/mlx5: fix statistics for error packets on vectorized Rx Date: Thu, 03 Aug 2017 23:28:42 +0200 Message-ID: <1835087.fN3h1d379y@xps> References: <20170802172554.17079-1-yskoh@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com To: Yongseok Koh Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 277732C16 for ; Thu, 3 Aug 2017 23:28:45 +0200 (CEST) In-Reply-To: <20170802172554.17079-1-yskoh@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/08/2017 19:25, Yongseok Koh: > If there's a Rx completion with error (e.g, MTU mismatch), it is handled > later out of main burst loop as a slow path for performance reason. > Statistics should be corrected by subtracting counters of errored packets. > Also, the last entry of mlx5_ptype_table[] must be RTE_PTYPE_ALL_MASK to > mark error in completion. > > Fixes: ea16068c0064 ("net/mlx5: fix L4 packet type support") > Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86") > > Signed-off-by: Yongseok Koh > Acked-by: Nelio Laranjeiro Applied, thanks