From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/3] mk: fix LDLIBS Date: Tue, 24 Oct 2017 02:15:49 +0200 Message-ID: <1835343.c7Vqvf7JSF@xps> References: <20171005125017.GA12160@bricha3-MOBL3.ger.corp.intel.com> <20171012160421.8337-1-olivier.matz@6wind.com> <9184057F7FC11744A2107296B6B8EB1E1400B993@FMSMSX108.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Eads, Gage" , "santosh.shukla@caviumnetworks.com" , "Richardson, Bruce" , "jerin.jacob@caviumnetworks.com" To: Olivier Matz Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id CAEC21B705 for ; Tue, 24 Oct 2017 02:15:51 +0200 (CEST) In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E1400B993@FMSMSX108.amr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/10/2017 16:39, Eads, Gage: > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > > > Some libraries in LDLIBS are currently generated from the > > DEPDIRS-$(dirname) variables in the Makefiles. This is valid when the > > subdirectory name match the library name, but it's not always the case, > > especially for PMDs. > > > > This series fixes some invalid dependency declarations first, and then removes > > the automatic generation of libraries from the directory names. Instead, the > > libraries are explicitly added in each Makefile. > > These three patches look good. I tested it on the contrived example from my original email, and this appears to fix the issue. > > Once the third patch's apply issues are resolved (http://dpdk.org/ml/archives/test-report/2017-October/032631.html): > Reviewed-by: Gage Eads Fixed some conflicts due to new PMDs and octeontx dependencies changes. Fixed some misses in patch 3 as explained in prior message. Applied with some fixes, thanks