From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 3/3] ethdev: prevent segfaults in
	rte_eth_dev_is_detachable
Date: Tue, 03 Nov 2015 12:10:43 +0100
Message-ID: <1835472.4si0y6iqvT@xps13>
References: <1446108903-14412-1-git-send-email-david.marchand@6wind.com>
 <1446108903-14412-4-git-send-email-david.marchand@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: David Marchand <david.marchand@6wind.com>,
 Maxime Leroy <maxime.leroy@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 4957E5A76
 for <dev@dpdk.org>; Tue,  3 Nov 2015 12:11:55 +0100 (CET)
Received: by wicll6 with SMTP id ll6so67312440wic.0
 for <dev@dpdk.org>; Tue, 03 Nov 2015 03:11:55 -0800 (PST)
In-Reply-To: <1446108903-14412-4-git-send-email-david.marchand@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-29 09:55, David Marchand:
> From: Maxime Leroy <maxime.leroy@6wind.com>
> 
> Some drivers like virtual ones don't specify any driver pointer in the
> structure rte_eth_dev.
> 
> To prevent segfault, we should check if this pointer is NULL before
> dereferencing it.
> 
> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
> Signed-off-by: David Marchand <david.marchand@6wind.com>

It is not clear what the problem is.
And the driver fields should probably be removed or changed as it too tigthly
related to the PCI driver.