From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 07/10] drivers/raw: introduce skeleton
	rawdev driver
Date: Wed, 31 Jan 2018 14:31:04 +0100
Message-ID: <1838229.CbHqTgKorz@xps>
References: <20180130145710.24757-1-shreyansh.jain@nxp.com>
 <20180131091318.7894-8-shreyansh.jain@nxp.com> <2766742.IHp3MJlWRC@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, hemant.agrawal@nxp.com, fiona.trahe@intel.com,
 rosen.xu@intel.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D02371B780
 for <dev@dpdk.org>; Wed, 31 Jan 2018 14:31:50 +0100 (CET)
In-Reply-To: <2766742.IHp3MJlWRC@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

31/01/2018 14:20, Thomas Monjalon:
> 31/01/2018 10:13, Shreyansh Jain:
> > Skeleton rawdevice driver, on the lines of eventdev skeleton, is for
> > showcasing the rawdev library. This driver implements some of the
> > operations of the library based on which a test module can be
> > developed.
> >=20
> > Design of skeleton involves a virtual device which is plugged into
> > VDEV bus on initialization.
> >=20
> > Also, enable compilation of rawdev skeleton driver.
> >=20
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> > ---
>=20
> It does not compile on 32-bit:
>=20
> drivers/raw/skeleton_rawdev/skeleton_rawdev.h:13:51: error:
> 	format =E2=80=98%lu=E2=80=99 expects argument of type =E2=80=98long unsi=
gned int=E2=80=99, but argument 6 has type =E2=80=98uint64_t {aka long long=
 unsigned int}=E2=80=99 [-Werror=3Dformat=3D]
>   rte_log(RTE_LOG_ ## level, skeleton_pmd_logtype, "%s(): " fmt "\n", \

=46ixed when applying:

=2D-- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
@@ -7,6 +7,7 @@
 #include <stdbool.h>
 #include <errno.h>
 #include <stdint.h>
+#include <inttypes.h>
 #include <string.h>
=20
 #include <rte_byteorder.h>
@@ -329,7 +330,7 @@ static int skeleton_rawdev_get_attr(struct rte_rawdev *=
dev,
                            SKELETON_ATTRIBUTE_NAME_MAX)) {
                        *attr_value =3D skeldev->attr[i].value;
                        done =3D 1;
=2D                       SKELETON_PMD_DEBUG("Attribute (%s) Value (%lu)",
+                       SKELETON_PMD_DEBUG("Attribute (%s) Value (%" PRIu64=
 ")",
                                           attr_name, *attr_value);
                        break;
                }