From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v7 7/8] examples/vhost_crypto: add vhost
	crypto sample application
Date: Sun, 15 Apr 2018 16:34:58 +0200
Message-ID: <1845545.r90AWaGVlL@xps>
References: <20180404142504.31836-1-roy.fan.zhang@intel.com>
 <20180405160137.56413-1-roy.fan.zhang@intel.com>
 <20180405160137.56413-8-roy.fan.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jianjay.zhou@huawei.com, maxime.coquelin@redhat.com,
 jianfeng.tan@intel.com, pawelx.wodkowski@intel.com
To: Fan Zhang <roy.fan.zhang@intel.com>, ferruh.yigit@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A40511B3C0
 for <dev@dpdk.org>; Sun, 15 Apr 2018 16:35:07 +0200 (CEST)
In-Reply-To: <20180405160137.56413-8-roy.fan.zhang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

05/04/2018 18:01, Fan Zhang:
> This patch adds vhost_crypto sample application to DPDK.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  examples/vhost_crypto/Makefile    |  32 +++
>  examples/vhost_crypto/main.c      | 541 ++++++++++++++++++++++++++++++++++++++
>  examples/vhost_crypto/meson.build |  14 +
>  3 files changed, 587 insertions(+)

There are 3 misses:

- not in examples/Makefile
- not in MAINTAINERS
- no documentation in doc/guides/sample_app_ug/

It won't be accepted in master as-is.