From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison Date: Tue, 15 May 2018 16:46:05 +0200 Message-ID: <1846600.PKkdRNXVvt@xps> References: <152627420173.53058.13179290989817984940.stgit@localhost.localdomain> <152627427362.53058.5993339273922161219.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, Andy Green To: "Mody, Rasesh" Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AC2671B820 for ; Tue, 15 May 2018 16:46:07 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/05/2018 00:16, Mody, Rasesh: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green > > Sent: Sunday, May 13, 2018 10:05 PM > >=20 > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c: > > In function =E2=80=98elink_check_kr2_wa=E2=80=99: > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28: > > error: bitwise comparison always evaluates to false [-Werror=3Dtautolog= ical- > > compare] > > ((next_page & 0xe0) =3D=3D 0x2)))); > >=20 > > This was fixed elsewhere in 2014 > >=20 > > Signed-off-by: Andy Green > > Fixes: b5bf7719221d ("bnx2x: driver support routines") > > Cc: stable@dpdk.org > > --- >=20 > Acked-by: Rasesh Mody I would appreciate a review of the 2 other bnx2x patches in this series, pl= ease.