From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] fbarray: add internal tailq for mapped areas Date: Thu, 28 Mar 2019 21:44:32 +0100 Message-ID: <1848003.AzJ49HI9Wz@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Anatoly Burakov Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3FDF22BD3 for ; Thu, 28 Mar 2019 21:44:35 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/02/2019 18:13, Anatoly Burakov: > Currently, there are numerous reliability issues with fbarray, > such as: > - There is no way to prevent attaching to overlapping memory > areas > - There is no way to prevent double-detach > - Failed destroy leaves fbarray in an invalid state (fbarray > itself is valid, but its backing memory area is already > detached) > > In addition, on FreeBSD, doing mmap() on a file descriptor > does not keep the lock, so we also need to store the fd > in order to keep the lock. > > This patch improves upon fbarray to address both of these > issues by adding an internal tailq to track allocated areas > and their respective file descriptors. > > Signed-off-by: Anatoly Burakov Applied, thanks