From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mempool: fix virt address mempool population Date: Mon, 14 May 2018 20:48:39 +0200 Message-ID: <1848737.7LY3OboWmP@xps> References: <014e66f8e34cb87fa126b7494ad644ef9ac68978.1526313945.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Olivier Matz , konstantin.ananyev@intel.com, arybchenko@solarflare.com, shreyansh.jain@nxp.com To: Anatoly Burakov Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id DBF321CAC2 for ; Mon, 14 May 2018 20:48:41 +0200 (CEST) In-Reply-To: <014e66f8e34cb87fa126b7494ad644ef9ac68978.1526313945.git.anatoly.burakov@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/05/2018 18:06, Anatoly Burakov: > Currently, populate_virt will check if mempool is already populated. > This will cause inability to reserve multi-chunk mempools if > contiguous memory is not a hard requirement, because if allocating > all-contiguous memory fails, mempool will retry with virtual addresses > and will call populate_virt. It seems that the original code never > anticipated more than one non-physically contiguous area. > > Fix it by removing the check in populate virt. populate_anon() function > calls populate_virt() also, and it can be reasonably inferred that it is > expecting that virtual area is not already populated. Even though a > similar check is already in place there, also add the check that was > part of populate_virt() just in case. > > Fixes: aab4f62d6c1c ("mempool: support no hugepage mode") If it is really the root cause, you need to add Cc: stable@dpdk.org. > Cc: olivier.matz@6wind.com > > Signed-off-by: Anatoly Burakov This patch looks sensible. It will wait some review, so it is a candidate for -rc4.