From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: force gcc to inline rte_movX function
Date: Tue, 17 Apr 2018 15:22:06 +0200
Message-ID: <1852475.4XxgDvW1hG@xps>
References: <20180412051636.240746-1-junjie.j.chen@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Junjie Chen <junjie.j.chen@intel.com>, bruce.richardson@intel.com,
 konstantin.ananyev@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 619127ED0
 for <dev@dpdk.org>; Tue, 17 Apr 2018 15:22:09 +0200 (CEST)
In-Reply-To: <20180412051636.240746-1-junjie.j.chen@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/04/2018 07:16, Junjie Chen:
> From: "Chen, Junjie" <junjie.j.chen@intel.com>
> 
> Sometimes gcc does not inline the function despite keyword *inline*,
> we obeserve rte_movX is not inline when doing performance profiling,
> so use *always_inline* keyword to force gcc to inline the function.
> 
> Signed-off-by: Chen, Junjie <junjie.j.chen@intel.com>
> ---
>  .../common/include/arch/x86/rte_memcpy.h           | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)

The title should start with "eal/x86:"
Something like that:
	eal/x86: force inlining of memcpy sub-functions

Bruce, Konstantin, any review of the content/optimization?