From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: Headers files with BSD license in kernel
Date: Wed, 10 Jun 2015 11:08:24 +0200
Message-ID: <1857272.JbxJmyvPRA@xps13>
References: <20150609174057.GA4394@linux.intel.com> <1927342.Zb0Nrj3NUW@xps13>
 <C6ECDF3AB251BE4894318F4E4512369780CAB547@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Bernal Marin, Miguel" <miguel.bernal.marin@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 9B9895AA0
 for <dev@dpdk.org>; Wed, 10 Jun 2015 11:09:19 +0200 (CEST)
Received: by wgv5 with SMTP id 5so30657413wgv.1
 for <dev@dpdk.org>; Wed, 10 Jun 2015 02:09:19 -0700 (PDT)
In-Reply-To: <C6ECDF3AB251BE4894318F4E4512369780CAB547@IRSMSX109.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-06-10 09:01, Burakov, Anatoly:
> > 2015-06-10 01:20, Zhang, Helin:
> > > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > > > > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > I'm working on Clear Linux project, and when I was integrating
> > > > > > > DPDK kernel modules to our kernel I found there are two
> > > > > > > headers with BSD License
> > > > > > >
> > > > > > > rte_pci_dev_feature_defs.h
> > > > > > > rte_pci_dev_features.h
> > > > > > >
> > > > > > > those are included in igb_uio module.
> > > > > > >
> > > > > > > Are those licenses correct?
> > > >
> > > > You can always escalate a BSD license to GPL, but the other way is not
> > allowed.
> > > > Ideally, the language on the file should make it clear that it is dual
> > licensed.
> > > > In an ideal world, igb_uio would go away, I am working on that.
> > >
> > > Yes, I agree with you. To be clearer, rte_pci_dev_feature_defs.h
> > > should be in dual liceses, and rte_pci_dev_features.h should be in GPL
> > license.
> > 
> > Yes, it is an error from this commit:
> > 	http://dpdk.org/browse/dpdk/commit/?id=88701645c98c9c88
> > These definitions were moved from a GPL file so they should keep the GPL
> > header.
> > Then it is used in EAL:
> > 	http://dpdk.org/browse/dpdk/commit/?id=ff0b67d1c868c19
> > So it must be dual licensed, like for rte_pci_dev_ids.h:
> > 	http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/
> > rte_pci_dev_ids.h
> 
> Agreed, should have been more careful. Should I make the patch to correct this?

You are welcome :)