From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] i40e: support of link flow control
Date: Thu, 13 Nov 2014 10:46:57 +0100
Message-ID: <1858688.dTAFT58TFH@xps13>
References: <1411888086-10818-1-git-send-email-zhida.zang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: zzang <zhida.zang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1411888086-10818-1-git-send-email-zhida.zang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Zhida,

> Add support of link flow control.
> 
> Signed-off-by: Zhida Zang <zhida.zang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Acked-by: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

I think you are reworking this patch, right?

I won't review it myself because I don't i40e enough.
I just have some minor comments:

> +static int i40e_10g_fc_enable(struct i40e_hw *hw, uint16_t pause_time)

"static int" should be on a separate line.

> +		PMD_INIT_LOG(ERR, "i40e_set_fc = %d\n", err);

Carriage return is already included in PMD_INIT_LOG now.

Thanks for keep us informed of the status of this patch.
-- 
Thomas