From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] pdump: fix vdev cleanup Date: Tue, 15 Jan 2019 11:10:37 +0100 Message-ID: <1859916.dnCeAC13tB@xps> References: <20190111174134.39772-1-reshma.pattan@intel.com> <3007842.nGy45PVQPd@xps> <3AEA2BF9852C6F48A459DA490692831F2A4009E2@irsmsx110.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "dev@dpdk.org" , "stable@dpdk.org" , "Yigit, Ferruh" To: "Pattan, Reshma" Return-path: In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A4009E2@irsmsx110.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/01/2019 11:09, Pattan, Reshma: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 11/01/2019 18:51, Reshma Pattan: > > > Virtual devices added in pdump application using rte_eal_hotplug_add > > > should be removed explicitly while existing the pdump application, > > > otherwise the > > > > existing -> exiting ? > > > > > subsequent run of the pdump application will fail with the reason that > > > virtual devices with the same name already exists in primary. > > > > > > Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev > > > attach") > > > CC: stable@dpdk.org > > > CC: ferruh.yigit@intel.com > > > > Why is it marked as a fix of this commit? > > Is it a miss in the conversion from ethdev attach calls? > > Or a changed behaviour with hotplug functions? > > It is changed behaviour with hotplug functions. Please, could you explain?