From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] ip_frag: fix hash key usage
Date: Wed, 28 Mar 2018 00:29:38 +0200
Message-ID: <1860185.tFcqzqpjh1@xps>
References: <1519178599-3661-1-git-send-email-sergey.alekseev@vdomresearch.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.ananyev@intel.com>
To: Sergey Alekseev <sergey.alekseev@vdomresearch.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 92F94A49A
 for <dev@dpdk.org>; Wed, 28 Mar 2018 00:29:54 +0200 (CEST)
In-Reply-To: <1519178599-3661-1-git-send-email-sergey.alekseev@vdomresearch.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

21/02/2018 03:03, Sergey Alekseev:
> ---
>  lib/librte_ip_frag/ip_frag_internal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Please we need an explanation and Signed-off-by.
Could you send a v2?

Do not hesitate to Cc Konstantin (maintainer of this lib) for reviews.
Thanks

> --- a/lib/librte_ip_frag/ip_frag_internal.c
> +++ b/lib/librte_ip_frag/ip_frag_internal.c
> @@ -61,7 +61,7 @@ ipv4_frag_hash(const struct ip_frag_key *key, uint32_t *v1, uint32_t *v2)
>  	uint32_t v;
>  	const uint32_t *p;
>  
> -	p = (const uint32_t *)&key->src_dst;
> +	p = (const uint32_t *) key->src_dst;
>  
>  #ifdef RTE_ARCH_X86
>  	v = rte_hash_crc_4byte(p[0], PRIME_VALUE);
> @@ -82,7 +82,7 @@ ipv6_frag_hash(const struct ip_frag_key *key, uint32_t *v1, uint32_t *v2)
>  	uint32_t v;
>  	const uint32_t *p;
>  
> -	p = (const uint32_t *) &key->src_dst;
> +	p = (const uint32_t *) key->src_dst;
>  
>  #ifdef RTE_ARCH_X86
>  	v = rte_hash_crc_4byte(p[0], PRIME_VALUE);