From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] doc: announce ethdev CRC strip flag
	deprecation
Date: Tue, 20 Mar 2018 12:35:27 +0100
Message-ID: <1863259.sHUX8Jkyl1@xps>
References: <20180320112631.107105-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Neil Horman <nhorman@tuxdriver.com>,
 John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B01835F19
 for <dev@dpdk.org>; Tue, 20 Mar 2018 12:45:23 +0100 (CET)
In-Reply-To: <20180320112631.107105-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/03/2018 12:26, Ferruh Yigit:
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> +* ethdev: Make CRC stript default behavior without any flag required and add a

s/stript/stripping/

> +  new offload flag to let application request for keeping CRC if PMD reports
> +  capability for it.
> +  ``DEV_RX_OFFLOAD_CRC_STRIP`` flag will be removed.
> +  ``DEV_RX_OFFLOAD_KEETP_CRC`` will be added.

s/KEETP/KEEP/

I think we should introduce the new flag without removing the old one
for one release.
Setting both flags would be an error.
Setting no flag would mean stripping.
So the CRC_STRIP flag would be just ignored by PMDs.

Opinions?