From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 0/6] cfgfile: config file parsing extension Date: Thu, 18 Jun 2015 14:44:13 +0200 Message-ID: <1866746.rYRfgnsu5l@xps13> References: <1434552528-3576-1-git-send-email-maciejx.t.gajdzica@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Pawel Wodkowski Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 905E3C640 for ; Thu, 18 Jun 2015 14:45:15 +0200 (CEST) Received: by wgez8 with SMTP id z8so62772624wge.0 for ; Thu, 18 Jun 2015 05:45:15 -0700 (PDT) In-Reply-To: <1434552528-3576-1-git-send-email-maciejx.t.gajdzica@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-17 16:48, Maciej Gajdzica: > Added new implementation of section parsing in config file. Refactore= d > existing code by spliting it to smaller functions. Changed section > allocation scheme and added new features - variable length entry val= ue > and line continue character '\'. >=20 > Pawel Wodkowski (6): > librte_cfgfile: fix code formating in header file > librte_compat: fix macro definition > cfgfile: split rte_cfgfile_load to smaller functions > cfgfile: added line continue character '\' to make multiline values= =20 > possible > cfgfile: fixed calling free for each section in rte_cfgfile_close > cfgfile: added new implementation of section parsing The shared library cannot link: =09syntax error in VERSION script > lib/librte_cfgfile/Makefile | 2 +- > lib/librte_cfgfile/rte_cfgfile.c | 793 ++++++++++++++++++= +++------- > lib/librte_cfgfile/rte_cfgfile.h | 52 +- > lib/librte_cfgfile/rte_cfgfile_version.map | 8 + > lib/librte_compat/rte_compat.h | 8 +- > 5 files changed, 653 insertions(+), 210 deletions(-) You forgot to update the example qos_sched (as previously noted): =09examples/qos_sched/cfg_file.c:485:47: error: =09passing argument 3 of =E2=80=98rte_cfgfile_section_entries=E2=80=99 = from incompatible pointer type