From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v11 07/24] driver: probe/remove common
	wrappers for PCI drivers
Date: Mon, 03 Oct 2016 16:21:28 +0200
Message-ID: <1868462.9szsyjFR7X@xps13>
References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com>
 <1474375296-26078-1-git-send-email-shreyansh.jain@nxp.com>
 <1474375296-26078-8-git-send-email-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, viktorin@rehivetech.com,
 David Marchand <david.marchand@6wind.com>, hemant.agrawal@nxp.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 521C958C8
 for <dev@dpdk.org>; Mon,  3 Oct 2016 16:21:31 +0200 (CEST)
Received: by mail-wm0-f53.google.com with SMTP id p138so154175538wmb.1
 for <dev@dpdk.org>; Mon, 03 Oct 2016 07:21:31 -0700 (PDT)
In-Reply-To: <1474375296-26078-8-git-send-email-shreyansh.jain@nxp.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-09-20 18:11, Shreyansh Jain:
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -4372,6 +4372,19 @@ rte_eth_dev_get_port_by_name(const char *name, uint8_t *port_id);
>  int
>  rte_eth_dev_get_name_by_port(uint8_t port_id, char *name);
>  
> +/**
> + * Wrapper for use by pci drivers as a .probe function to attach to a ethdev
> + * interface.
> + */
> +int rte_eth_dev_pci_probe(struct rte_pci_driver *pci_drv,
> +			  struct rte_pci_device *pci_dev);
> +
> +/**
> + * Wrapper for use by pci drivers as a .remove function to detach a ethdev
> + * interface.
> + */
> +int rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev);

These functions are used by the drivers only (as helpers).
So they should be marked @internal (added after applying the patch).