From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mem: fix alignment of requested virtual areas Date: Wed, 18 Jul 2018 23:23:22 +0200 Message-ID: <1869059.f4TMTciHnY@xps> References: <1e4e38f022da0d791b454b8d9cddce61b479b7ad.1531752592.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Stojaczyk, DariuszX" , "Yao, Lei A" , "stable@dpdk.org" To: "Burakov, Anatoly" Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/07/2018 11:48, Stojaczyk, DariuszX: > From: Burakov, Anatoly > > > > The original code did not align any addresses that were requested as > > page-aligned, but were different because addr_is_hint was set. > > > > Below fix by Dariusz has introduced an issue where all unaligned addresses > > were left as unaligned. > > > > This patch is a partial revert of > > commit 7fa7216ed48d ("mem: fix alignment of requested virtual areas") > > > > and implements a proper fix for this issue, by asking for alignment in all > > but the following two cases: > > > > 1) page size is equal to system page size, or > > 2) we got an aligned requested address, and will not accept a different one > > > > This ensures that alignment is performed in all cases, except for those we > > can guarantee that the address will not need alignment. > > > > Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory") > > Fixes: 7fa7216ed48d ("mem: fix alignment of requested virtual areas") > > Cc: dariuszx.stojaczyk@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Anatoly Burakov > > Acked-by: Dariusz Stojaczyk Applied, thanks