From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v10 0/7] Expanded statistics reporting
Date: Thu, 23 Feb 2017 09:45:27 +0100
Message-ID: <1873092.o3R52VP9cS@xps13>
References: <1486118019-2280-1-git-send-email-remy.horton@intel.com>
 <2924793.QDCoddA1K3@xps13> <fa5fdcb8-61e7-e665-fc84-8626aeffea7a@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 6D4E64A65
 for <dev@dpdk.org>; Thu, 23 Feb 2017 09:45:29 +0100 (CET)
Received: by mail-wm0-f43.google.com with SMTP id v77so5247132wmv.0
 for <dev@dpdk.org>; Thu, 23 Feb 2017 00:45:29 -0800 (PST)
In-Reply-To: <fa5fdcb8-61e7-e665-fc84-8626aeffea7a@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-02-23 07:09, Remy Horton:
> 
> On 16/02/2017 10:53, Thomas Monjalon wrote:
> > 2017-02-03 10:33, Remy Horton:
> [..]
> > I think there are three remaining questions:
> > - When the metrics computation are done? (in which thread?)
> 
> Actual calculation is not done by libmetrics itself - it only handles
> distribution. Calculation is done prior to the calculated values being
> passed to rte_metrics_update_value*(), so the thread that does the
> calculation is a decision for the application.

Of course computation is not done in libmetrics. The question was about
its integration in the application and the perfromance impact.
Should it be in the dataplane threads or in separate threads?

> > - May the few lines of computation code be done differently when tightly
> > integrated in an application logic?
> 
> Yes, since it is the application itself (or in the case of bit-rate, a
> separate library) that does the calculation.

The question was more about the cache misses with this library.

> > - Could it be hosted in a separate repository on dpdk.org?
> 
> That's part of a broader discussion on how DPDK is packaged.

And specifically for these metrics libraries, do you agree it could
be packaged separately?