From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] app/testpmd: fix testpmd exit using ctrl+d
Date: Tue, 24 Jul 2018 13:25:23 +0200
Message-ID: <1876510.4y0gDTZx5Q@xps>
References: <20180723104425.10090-1-jasvinder.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bernard.iremonger@intel.com, reshma.pattan@intel.com,
 motih@mellanox.com, olivier.matz@6wind.com
To: Jasvinder Singh <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C9802235
 for <dev@dpdk.org>; Tue, 24 Jul 2018 13:25:30 +0200 (CEST)
In-Reply-To: <20180723104425.10090-1-jasvinder.singh@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

23/07/2018 12:44, Jasvinder Singh:
> Fix testpmd app exit by pressing ctrl+d, End-of-Transmission character (EOT)
> on the empty command line.

Please describe what is the issue and what is the cause.

> Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
> 
> Reported-by: Mordechay Haimovsky <motih@mellanox.com>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  app/test-pmd/cmdline.c       | 10 ++++++----
>  lib/librte_cmdline/cmdline.c |  2 +-

It is very suspicious to change the cmdline library.
If there is a bug in this library, it deserves a separate fix.