From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples/ip_pipeline: fix freebsd build error Date: Tue, 10 Apr 2018 00:34:14 +0200 Message-ID: <1876749.P1BhTyUkUM@xps> References: <20180409120632.38567-1-jasvinder.singh@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, cristian.dumitrescu@intel.com To: Jasvinder Singh Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 30DA11BA07 for ; Tue, 10 Apr 2018 00:34:17 +0200 (CEST) In-Reply-To: <20180409120632.38567-1-jasvinder.singh@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/04/2018 14:06, Jasvinder Singh: > IP_Pipeline app is not supported in FreeBSD environment. Therefore, > skip it while building the sample apps on FreeBSD. > > Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface") > Fixes: 2f74ae28e23f ("examples/ip_pipeline: add tap object") > > Signed-off-by: Jasvinder Singh > --- > --- a/examples/ip_pipeline/Makefile > +++ b/examples/ip_pipeline/Makefile > +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") > +$(error This application can only operate in a linuxapp environment, \ > +please change the definition of the RTE_TARGET environment variable) > +endif It is not skipping the example, just throwing an error (which is needed). You should add a test in examples/Makefile to really skip it.