From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 5/6] eal: remove xen dom0 support
Date: Tue, 05 Sep 2017 10:34:38 +0200
Message-ID: <1877951.5TUJrl4YNn@xps>
References: <1504116634-115687-1-git-send-email-jianfeng.tan@intel.com>
 <18154944.ikgZCrDS5M@xps>
 <ED26CBA2FAD1BF48A8719AEF02201E36512B0439@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>, dev@dpdk.org,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Mcnamara,
 John" <john.mcnamara@intel.com>,
 "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 "shahafs@mellanox.com" <shahafs@mellanox.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D383B2C15
 for <dev@dpdk.org>; Tue,  5 Sep 2017 10:34:40 +0200 (CEST)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E36512B0439@SHSMSX103.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/09/2017 10:07, Tan, Jianfeng:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 05/09/2017 05:41, Tan, Jianfeng:
> > > From: Richardson, Bruce
> > > >
> > > > Reading the contributors guide section on ABI, specifically
> > > > http://dpdk.org/doc/guides/contributing/versioning.html#deprecating-
> > an-
> > > > entire-abi-version
> > > > it seems like we should collapse down the versions to a single one
> > > > following the function removal, and also increment the whole library so
> > > > version.
> > >
> > > So for lib/librte_eal/linuxapp/eal/rte_eal_version.map, we should change
> > it in below way?
> > >
> > > DPDK_2.1 {
> > >         {APIs in DPDK_2.0 except xen APIs}
> > >         ...
> > > };
> > >
> > > DPDK_16.04 {
> > >         {APIs in DPDK_2.1 except xen APIs}
> > >         ...
> > > } DPDK_2.1;
> > 
> > No, you don't need to collapse. You can just remove Xen functions.
> 
> Thanks.
> 
> Besides, two more things: 
> 1. Shall we increase the so version?

Yes

> 2. This patch is about 8K lines long, do we need to split?

I do not know how you can split a removal.
If you have ideas, feel free.