From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/2] ixgbe: check mbuf refcnt when clearing RX/TX ring Date: Fri, 03 Jul 2015 17:46:55 +0200 Message-ID: <1879755.kzD1mjHoUo@xps13> References: <1435938006-22254-1-git-send-email-bruce.richardson@intel.com> <1435938006-22254-3-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 383415A43 for ; Fri, 3 Jul 2015 17:48:06 +0200 (CEST) Received: by wgqq4 with SMTP id q4so91615709wgq.1 for ; Fri, 03 Jul 2015 08:48:06 -0700 (PDT) In-Reply-To: <1435938006-22254-3-git-send-email-bruce.richardson@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-03 16:40, Bruce Richardson: > The function to clear the TX ring when a port was being closed, e.g. on > exit in testpmd, was not checking the mbuf refcnt before freeing it. > Since the function in the vector driver to clear the ring after TX does > not set the pointer to NULL post-free, this caused crashes if mbuf > debugging was turned on. Please, could you add a Fixes: line to reference the origin of the bug? Thanks