From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/9] fix hotplug API Date: Sun, 09 Jul 2017 16:19:05 +0200 Message-ID: <1881782.F5Es4knhFG@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Gaetan Rivet , Shreyansh Jain , Stephen Hemminger , Bruce Richardson To: Jan Blunck Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E54FE58D1 for ; Sun, 9 Jul 2017 16:19:06 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/07/2017 12:38, Jan Blunck: > On Sat, Jul 8, 2017 at 9:45 PM, Gaetan Rivet wrote: > > Sending those fixes as separate patches as they stand on their own. > > This series improves usability of the hotplug API and fixes a few issues > > with existing implementations. > > > > Interesting that you send this series as fixes. From what I can tell > this is a collection of changes that you have proposed before and I > have commented on and requested changes for. But I don't see that they > have been addressed at all: > > - you still concatenate the bus and device name just to pass it down > to the buses and parse it into its components again > - you still delegate the devargs parsing to the buses > > Please fix this issues. If you really want to return a device handle > from the hotplug API please present the use-case and in which cases > this solves a real-world problem. Please Jan, could you check in the 9 patches of this series which ones are OK for you? Thank you