From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] crypto/scheduler: fix build with gcc 8.2 Date: Sun, 04 Nov 2018 22:01:00 +0100 Message-ID: <1884211.o4Xx1SxZqB@xps> References: <20181103145828.24564-1-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, Fan Zhang , "ferruh.yigit@intel.com" , "Jacob, Jerin" , "stable@dpdk.org" To: Jerin Jacob Return-path: In-Reply-To: <20181103145828.24564-1-jerin.jacob@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2018 15:58, Jerin Jacob: > build_error: >=20 > drivers/crypto/scheduler/scheduler_pmd.c: In function =E2=80=98parse_name= _arg=E2=80=99: > drivers/crypto/scheduler/scheduler_pmd.c:372:2: error: =E2=80=98strncpy= =E2=80=99 > specified bound 64 equals destination size [-Werror=3Dstringop-truncation] > strncpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > strncpy may result a not null-terminated string, > replaced it with strlcpy >=20 > Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jerin Jacob Applied, thanks