From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/3] i40e: enable extended tag Date: Mon, 25 Jan 2016 10:16:32 +0100 Message-ID: <1884621.9QzzlocIgN@xps13> References: <1450665486-8335-1-git-send-email-helin.zhang@intel.com> <3789056.EpDHogkSc1@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Zhang, Helin" Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id CD2AB8D9C for ; Mon, 25 Jan 2016 10:17:37 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id n5so69046284wmn.0 for ; Mon, 25 Jan 2016 01:17:37 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-12-21 10:38, Helin Zhang: > > > PCIe feature of 'Extended Tag' is important for 40G performance. > > > It adds its enabling during each port initialization, to ensure the > > > high performance. > > > > If it's so important, why the values are not documented? > > Please start to fill a file doc/guides/nics/i40e.rst to explain how the > > device works. Thanks > > It has already been mentioned in getting started guide for a long time. > Are you suggesting to move into i40e specifically? Thanks! Yes you're right. I had forgotten that: http://dpdk.org/doc/guides-2.2/linux_gsg/enable_func.html#enabling-extended-tag-and-setting-max-read-request-size Yes, it would be better moved into an i40e doc. And maybe max_read_request_size may be commented to give advices on values. Thanks