From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v8 13/14] ethdev: Use embedded rte_device to
	detach driver
Date: Tue, 04 Jul 2017 01:17:49 +0200
Message-ID: <1885216.VTJsdQy0gT@xps>
References: <20170629182206.1072-1-jblunck@infradead.org>
 <20170630181943.23929-1-jblunck@infradead.org>
 <20170630181943.23929-14-jblunck@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com
To: Jan Blunck <jblunck@infradead.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id ECD1C2935
 for <dev@dpdk.org>; Tue,  4 Jul 2017 01:17:51 +0200 (CEST)
In-Reply-To: <20170630181943.23929-14-jblunck@infradead.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

30/06/2017 20:19, Jan Blunck:
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -439,7 +439,8 @@ rte_eth_dev_detach(uint8_t port_id, char *name)
>  
>         snprintf(name, sizeof(rte_eth_devices[port_id].data->name),
>                  "%s", rte_eth_devices[port_id].data->name);
> -       ret = rte_eal_dev_detach(name);
> +
> +       ret = rte_eal_dev_detach(rte_eth_devices[0].device);

Obviously, I change rte_eth_devices[0] to rte_eth_devices[port_id].