From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 00/27] Add i40e PMD support Date: Wed, 18 Jun 2014 11:23:55 +0200 Message-ID: <1886490.uKY7E5th3Z@xps13> References: <1401944951-23783-1-git-send-email-helin.zhang@intel.com> <3908766.ykkJEPOGFU@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Zhang, Helin" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-06-18 08:51, Zhang, Helin: > Thomas Monjalon: > > Some things could be cleaned up later, especially i40e specific flags in > > generic API must be removed. Please work on a patch for next release. > > Btw, what do you mean the i40e specific flags in generic API? Did you mean > the new flags defined in rte_mbuf.h? Yes, we are working on some bug fixes > and enhancements which might need to be added in the next release. I mean that RSS flags are really Intel-specific. In case other NIC vendors would use this RSS API, it can be a problem to address. But we can wait for this one. About mbuf flags, they are all zeros and useless. So a patch is needed to get some space and define new values (as you already explained). And last but not the least, RTE_LIBRTE_I40E_16BYTE_RX_DESC handling is very strange as it can be seen in this commit: http://dpdk.org/browse/dpdk/commit/?id=ac2ece3fb1f5511 -- Thomas