From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] vhost: add support for dynamic vhost PMD creation Date: Thu, 19 May 2016 18:44:44 +0200 Message-ID: <1891939.OmQDtN0y3O@xps13> References: <20160509213124.GK5641@yliu-dev.sh.intel.com> <38538365.t1P5Ut1YhZ@xps13> <573DE9BE.4070807@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Tetsuya Mukawa , Yuanhan Liu To: Ferruh Yigit Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 9C73695FD for ; Thu, 19 May 2016 18:44:58 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id n129so239295421wmn.1 for ; Thu, 19 May 2016 09:44:58 -0700 (PDT) In-Reply-To: <573DE9BE.4070807@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-05-19 17:28, Ferruh Yigit: > On 5/19/2016 9:33 AM, Thomas Monjalon wrote: > > 2016-05-18 18:10, Ferruh Yigit: > >> Add rte_eth_from_vhost() API to create vhost PMD dynamically from > >> applications. > > > > How is it different from rte_eth_dev_attach() calling rte_eal_vdev_init()? > > > > When used rte_eth_dev_attach(), application also needs to do: > rte_eth_dev_configure() > rte_eth_rx_queue_setup() > rte_eth_tx_queue_setup() > rte_eth_dev_start() > > rte_eth_from_vhost() does these internally, easier to use for applications. This argument is not sufficient. We are not going to add new APIs just for wrapping others.