From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 08/24] rte_ring_generic.h: stack
	declarations before code
Date: Mon, 14 May 2018 01:44:56 +0200
Message-ID: <1896621.ibENEg8Kdi@xps>
References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain>
 <1908380.h0rCPQG6nq@xps> <2c8be5ff-70ef-6081-31f5-bcbb8a0b1a18@warmcat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com
To: Andy Green <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 9DD211BD37
 for <dev@dpdk.org>; Mon, 14 May 2018 01:44:58 +0200 (CEST)
In-Reply-To: <2c8be5ff-70ef-6081-31f5-bcbb8a0b1a18@warmcat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/05/2018 01:21, Andy Green:
> 
> On 05/14/2018 12:47 AM, Thomas Monjalon wrote:
> > 12/05/2018 03:59, Andy Green:
> >> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:
> >> In function '__rte_ring_move_prod_head':
> >> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3:
> >> warning: ISO C90 forbids mixed declarations and code
> >> [-Wdeclaration-after-statement]
> >>     const uint32_t cons_tail = r->cons.tail;
> >>     ^~~~~
> >> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:
> >> In function '__rte_ring_move_cons_head':
> >> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:147:3:
> >> warning: ISO C90 forbids mixed declarations and code
> >> [-Wdeclaration-after-statement]
> >>     const uint32_t prod_tail = r->prod.tail;
> > 
> > The fix line is:
> > Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation")
> 
> OK... people can just use git blame at the time they want to know this 
> though.

No, we need it to automatically detect which commits should be backported,
and in which branch.

We also add Cc: stable@dpdk.org to confirm explicitly that is must be backported.