From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/ring: fix adding MAC addresses
Date: Tue, 30 May 2017 13:45:09 +0100
Message-ID: <18fd544d-1a3c-b4c7-67c8-0b6502b28bf5@intel.com>
References: <1495804685-26501-1-git-send-email-ciwillia@brocade.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: bruce.richardson@intel.com
To: "Charles (Chas) Williams" <ciwillia@brocade.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id CD29B3252
 for <dev@dpdk.org>; Tue, 30 May 2017 14:45:12 +0200 (CEST)
In-Reply-To: <1495804685-26501-1-git-send-email-ciwillia@brocade.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/26/2017 2:18 PM, Charles (Chas) Williams wrote:
> When .mac_addr_add() was changed to allow a return code, ring was changed
> to return -ENOTSUP.  This changes the behavior of the rte_ring driver in
> a way that does not maintain backward compatibility.  Additionally, if
> the intent is to return -ENOTSUP, you could simply not define the stubs.
> 
> Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address")
> 
> Signed-off-by: Chas Williams <ciwillia@brocade.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>