From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] lib/librte_ether: Prevent link status race condition when LSI enabled Date: Wed, 04 Nov 2015 23:13:41 +0100 Message-ID: <1905391.mr0njJUdyB@xps13> References: <5406727.UN0rhZ0d4I@xps13> <1445981935-3559-1-git-send-email-tim.shearer@overturenetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Tim Shearer Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id DC5758E9F for ; Wed, 4 Nov 2015 23:15:10 +0100 (CET) Received: by wmll128 with SMTP id l128so3550824wml.0 for ; Wed, 04 Nov 2015 14:15:10 -0800 (PST) In-Reply-To: <1445981935-3559-1-git-send-email-tim.shearer@overturenetworks.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-27 17:38, Tim Shearer: > Calling the Ethernet driver's link_update function from rte_eth_dev_start can result in a race condition if the NIC raises the link interrupt at the same time. Depending on the interrupt handler implementation, the race can cause the it to think that it received two consecutive link up interrupts, and it exits without calling the user callback. Appears to impact E1000/IGB and virtio drivers only. > > Signed-off-by: Tim Shearer Applied, thanks