From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 3/6] bus: introduce device level DMA
	memory mapping
Date: Wed, 13 Mar 2019 12:19:22 +0100
Message-ID: <1907286.xmCKSEcAjO@xps>
References: <cover.1551793527.git.shahafs@mellanox.com>
 <1698312.TEgN2QzQvo@xps>
 <AM0PR0502MB3795D92D8DB68B66A5823F28C34A0@AM0PR0502MB3795.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, Yongseok Koh <yskoh@mellanox.com>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
 "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 9BB16568A
 for <dev@dpdk.org>; Wed, 13 Mar 2019 12:19:26 +0100 (CET)
In-Reply-To: <AM0PR0502MB3795D92D8DB68B66A5823F28C34A0@AM0PR0502MB3795.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/03/2019 12:12, Shahaf Shuler:
> From: Thomas Monjalon <thomas@monjalon.net>
> > > +/**
> > > + * Device level DMA map function.
> > > + * After a successful call, the memory segment will be mapped to the
> > > + * given device.
> > > + *
> > > + * @note: Memory must be registered in advance using rte_extmem_*
> > APIs.
> > 
> > Could we make more explicit that this function is part of the "external
> > memory API"?
> 
> How do you suggest? 

There could be an explicit comment.

> This function belongs to rte_dev therefore the rte_dev prefix. better rte_dev_extmem_dma_map ?

Not sure about the prefix. Anatoly?