From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] rte.extvars.mk: allow overriding RTE_SDK_BIN from the environment Date: Wed, 27 Jan 2016 14:38:29 +0100 Message-ID: <1907511.MEp49p1vlo@xps13> References: <1453267824-2880-1-git-send-email-mhall@mhcomputing.net> <2864842.XzLbtfflbQ@xps13> <56A0696A.8090506@mhcomputing.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Matthew Hall Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 0464E95AB for ; Wed, 27 Jan 2016 14:39:39 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id l66so3028190wml.0 for ; Wed, 27 Jan 2016 05:39:39 -0800 (PST) In-Reply-To: <56A0696A.8090506@mhcomputing.net> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-01-20 21:15, Matthew Hall: > On 1/20/16 7:27 AM, Thomas Monjalon wrote: > > Hi Matthew, > > > > RTE_SDK_BIN is an internal variable and should not be overriden. > > > > Have you installed DPDK somewhere? Example: > > make install O=mybuild DESTDIR=mylocalinstall > > > > Then you should build your app like this: > > make RTE_SDK=$(readlink -e ../dpdk/mylocalinstall/usr/local/share/dpdk) > > Hello Thomas, > > Is the way the make install target really works documented somewhere? It is poorly described here: http://dpdk.org/doc/guides/prog_guide/dev_kit_root_make_help.html#install-targets > This target did not exist when I first used DPDK in 2011, and since then > I saw various documentation on building DPDK in various places, but not > that much explanation what make install actually does. I recall various > list threads about changing its behavior as well. Historically, "make install" was a convenient default build (with T= option). The DESTDIR option was added to make a real install after building. The standard form (without T=) is now implemented to do a real install. > For example, if I look at this apparently most official document: > > http://dpdk.org/doc/guides/linux_gsg/build_dpdk.html > > It has build examples such as: > > make install T=x86_64-native-linuxapp-gcc This command finishes with this message: Installation cannot run with T defined and DESTDIR undefined Yes you are right, some docs are neither complete nor up-to-date. Volunteers are welcome. > But it does not discuss "O=" or "DESTDIR=" or any other additional > options. From some experiments on my machine, it looks like maybe I > could do this: > > make install "T=${RTE_TARGET}" "O=build" "DESTDIR=build" > > Is that a valid possibility, to keep it all in one easy directory? Yes you can install where you want. Note that this command (with T= and O=) will build in the directory $O/$T i.e. build/${RTE_TARGET} and install in build/ Please confirm that this patch is not needed. Thanks