From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2] kni: bug fix for compile issue in KNI on
	Fedora 18 with kernel 3.6.10
Date: Thu, 22 May 2014 16:32:51 +0200
Message-ID: <1909311.37348vjfnn@xps13>
References: <1400729717-6195-1-git-send-email-helin.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1400729717-6195-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-05-22 11:35, Helin Zhang:
> Error of "implicit-function-declaration" can be seen when building KNI
> kernel module on Linux kernel 3.6.10 platform, as follows.
> "x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c:
> In function \u2018igb_get_eee\u2019:
> x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c:
>   2441:4: error: implicit declaration of function
>   \u2018mmd_eee_adv_to_ethtool_adv_t\u2019
>   [-Werror=implicit-function-declaration]
> x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c:
>  In function \u2018igb_set_eee\u2019:
> x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c:
>   2551:2: error: implicit declaration of function
>   \u2018ethtool_adv_to_mmd_eee_adv_t\u2019
>   [-Werror=implicit-function-declaration]"
> 
> The root cause is as follows.
> On Fedora 18 with kernel 3.6.10, ETHTOOL_GEEE is defined in Linux
> header file of "linux/ethtool.h", while is not defined in most of other
> linux kernel versions.
> mmd_eee_cap_to_ethtool_sup_t(), mmd_eee_adv_to_ethtool_adv_t() and
> ethtool_adv_to_mmd_eee_adv_t() in kcompat.h are disabled by "#if
> !defined(ETHTOOL_GEEE) || (RHEL_RELEASE_CODE && RHEL_RELEASE_CODE <=
> RHEL_RELEASE_VERSION(6,4))", while are called in igb_get_eee() in
> igb_ethtool.c which is enabled by "#ifdef ETHTOOL_GEEE".
> 
> Signed-off-by: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied for version 1.7.0.

Thanks
-- 
Thomas