From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gregory Etelson <gregory@weka.io>
Subject: Re: [PATCH v2] igb_uio: issue FLR during open and
	release of device file
Date: Mon, 10 Jul 2017 06:07:45 +0300
Message-ID: <1912538.AEa4I0QC60@polaris>
References: <1497260285-27536-1-git-send-email-shijith.thotton@caviumnetworks.com>
 <1499426031-2664-1-git-send-email-shijith.thotton@caviumnetworks.com>
 <5cf77ba2-8c29-ca31-1141-63ca01eff9f5@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Shijith Thotton <shijith.thotton@caviumnetworks.com>, dev@dpdk.org,
 Thomas Monjalon <thomas@monjalon.net>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Jianfeng Tan <jianfeng.tan@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
 [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 713B0568A
 for <dev@dpdk.org>; Mon, 10 Jul 2017 05:07:47 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id k67so119322437wrc.2
 for <dev@dpdk.org>; Sun, 09 Jul 2017 20:07:47 -0700 (PDT)
In-Reply-To: <5cf77ba2-8c29-ca31-1141-63ca01eff9f5@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Ferruh,

I could not reproduce server crash with the patch.
However, some tests report ixgbe_vf_pmd and i40e_vf_pmd 
do not receive and transmit frames after process restart,
although PMD initialization completed successfully
Is there a way to collect PF firmware dump for investigation ?

Regards,
Gregory

On Friday, 7 July 2017 18:10:40 IDT Ferruh Yigit wrote:
> On 7/7/2017 12:13 PM, Shijith Thotton wrote:
> > Set UIO info device file operations open and release. Call pci reset
> > function inside open and release to clear device state at start and end.
> > Copied this behaviour from vfio_pci kernel module code. With this patch,
> > it is not mandatory to issue FLR by PMD's during init and close.
> > 
> > Bus master enable and disable are added in open and release respectively
> > to take care of device DMA.
> > 
> > Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
> 
> Gregory,
> 
> Would you mind testing this one?
> 
> Thanks,
> ferruh
> 
>