From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 0/8] eal: dynamic logs
Date: Wed, 05 Apr 2017 13:50:58 +0200
Message-ID: <1913108.MtspqzMU4y@xps13>
References: <20170329155323.4760-1-olivier.matz@6wind.com>
 <20170404164040.24132-1-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com,
 jerin.jacob@caviumnetworks.com, pablo.de.lara.guarch@intel.com
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f182.google.com (mail-wr0-f182.google.com
 [209.85.128.182]) by dpdk.org (Postfix) with ESMTP id 301A51E20
 for <dev@dpdk.org>; Wed,  5 Apr 2017 13:51:01 +0200 (CEST)
Received: by mail-wr0-f182.google.com with SMTP id w43so10398758wrb.0
 for <dev@dpdk.org>; Wed, 05 Apr 2017 04:51:01 -0700 (PDT)
In-Reply-To: <20170404164040.24132-1-olivier.matz@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-04 18:40, Olivier Matz:
> The objective of this patchset is to introduce a framework to
> support dynamic log types in EAL. It also provides one example of use
> (in i40e).
> 
> Features:
> - log types are identified by a string
> - at registration, a uniq identifier is associated to a log type
> - each log type can have its level changed dynamically
> - extend command line parameters to set the log level of a specific
>   type, or logs matching a regular expression
> - keep compat with other legacy types (eal, malloc, ring, user*,
>   etc... keep their hardcoded log type value)

Applied, thanks

> Next step is to adapt drivers, libs and apps to use this new API. At the
> end, we can expect that all non-dataplane logs are moved to be dynamic,
> so we can enable/disable them at runtime, without recompiling. Many
> debug options can probably be removed from configuration:
>   $ git grep DEBUG config/common_base | wc -l
>   89

Please maintainers, let's remove these useless DEBUG options!
Thanks