From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue Date: Mon, 21 May 2018 16:22:33 +0200 Message-ID: <1913991.jNxr5nhODZ@xps> References: <1526478813-154172-1-git-send-email-rosen.xu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, roy.fan.zhang@intel.com, declan.doherty@intel.com, bruce.richardson@intel.com, shreyansh.jain@nxp.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, tianfei.zhang@intel.com, song.liu@intel.com, hao.wu@intel.com, gaetan.rivet@6wind.com To: Rosen Xu Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 035A11B1B4 for ; Mon, 21 May 2018 16:22:41 +0200 (CEST) In-Reply-To: <1526478813-154172-1-git-send-email-rosen.xu@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/05/2018 15:53, Rosen Xu: > Fix coverity issue: 279449 > > Signed-off-by: Rosen Xu > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Coverity issue: 279449 > Cc: stable@dpdk.org Not for stable > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > @@ -227,7 +227,7 @@ > int file_fd; > int ret = 0; > ssize_t buffer_size; > - void *buffer; > + void *buffer = NULL; It is not fixing anything. This variable cannot be read before being written.