From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/6] eal: eal stub to add windows support
Date: Fri, 01 Mar 2019 15:30:09 +0100
Message-ID: <1915046.8TnCJQ7qTk@xps>
References: <20190301071847.13376-1-anand.rawat@intel.com>
 <1633455.prhy9BIAj0@xps>
 <20190301141717.GA325020@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, pallavi.kadam@intel.com, jeffrey.b.shaw@intel.com,
 ranjit.menon@intel.com
To: Bruce Richardson <bruce.richardson@intel.com>,
 Anand Rawat <anand.rawat@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AE1192BB5
 for <dev@dpdk.org>; Fri,  1 Mar 2019 15:30:12 +0100 (CET)
In-Reply-To: <20190301141717.GA325020@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

01/03/2019 15:17, Bruce Richardson:
> On Fri, Mar 01, 2019 at 03:03:02PM +0100, Thomas Monjalon wrote:
> > 01/03/2019 08:18, Anand Rawat:
> > > +elif host_machine.system() == 'windows' +
> > > dpdk_conf.set('RTE_EXEC_ENV_WINDOWS', 1)
> > 
> > For consistency, it should RTE_EXEC_ENV_WINAPP.
> > 
> For this one you can partially blame me - early internal review suggested
> changing to winapp, but I suggested holding off on the change for community
> consensus. Personally, I  would prefer a little inconsistency and keep it
> as windows for clarity. In future, I also think we should just rename
> linxuapp to linux, and bsdapp to freebsd!

OK I agree to remove APP suffixes.

> However, for now, if the majority prefer winapp, I'm ok with it. [Though I
> can't help reading it as winamp half the time! No llamas involved here
> though!]