From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v9 3/4] examples: add l3fwd-thread example in
	performance-thread
Date: Tue, 08 Dec 2015 02:35:43 +0100
Message-ID: <1915132.14VGSMCEh2@xps13>
References: <1449225265-14480-2-git-send-email-ian.betts@intel.com>
 <1449511120-16899-1-git-send-email-ian.betts@intel.com>
 <1449511120-16899-4-git-send-email-ian.betts@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ian Betts <ian.betts@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id A7A6AFFA
 for <dev@dpdk.org>; Tue,  8 Dec 2015 02:36:56 +0100 (CET)
Received: by wmec201 with SMTP id c201so191725287wme.0
 for <dev@dpdk.org>; Mon, 07 Dec 2015 17:36:56 -0800 (PST)
In-Reply-To: <1449511120-16899-4-git-send-email-ian.betts@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-07 17:58, Ian Betts:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -575,3 +575,10 @@ F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst
>  M: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>  M: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>  F: examples/ptpclient/
> +
> +M: Ian Betts <ian.betts@intel.com>
> +F: examples/performance-thread/
> +
> +M: Ian Betts <ian.betts@intel.com>
> +M: John McNamara <john.mcnamara@intel.com>
> +F: doc/guides/sample_app_ug/performance_thread.rst

Why doing 2 sections?
John is already the doc maintainer. You don't need to add him here.

> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -77,5 +77,9 @@ DIRS-y += vmdq
>  DIRS-y += vmdq_dcb
>  DIRS-$(CONFIG_RTE_LIBRTE_POWER) += vm_power_manager
>  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += l2fwd-crypto
> -
> +ifneq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),)
> +ifneq ($(CONFIG_RTE_ARCH_X86_64),)
> +DIRS-y += performance-thread
> +endif
> +endif

Matter of taste, I would prefer DIRS-$(CONFIG_RTE_ARCH_X86_64)