From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: New driver (large patch) question. Date: Wed, 02 Mar 2016 22:54:15 +0100 Message-ID: <1915798.D06pWLxedU@xps13> References: <20160302082450.6f64cf8e@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Stephen Hurd Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 830F529D6 for ; Wed, 2 Mar 2016 22:55:52 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id n186so106130785wmn.1 for ; Wed, 02 Mar 2016 13:55:52 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-02 13:30, Stephen Hurd: > The bulk of the patch is the hardware interface header file. With all the > comments, it weighs in around 800k. If I strip the comments, it's around > 300k. If I both strip all the comments and remove all the currently unused > structures, I can get the entire patch down just below 300k, but that makes > it much harder for someone to do further development. I'm willing to do > that though if it's what's preferred. > > The other large file (560k) is just a bunch of extra debug output that > makes it easier to debug issues. It's normally not compiled, so it sounds > like it's not wanted either. If the code is not needed, it's obviously better to not submit it :) > I'll submit without comments in the hardware interface file and take it > from there. I don't think removing the comments is a good option. Please try to split per-feature to make it readable. You can check how fm10k was introduced as an example: http://thread.gmane.org/gmane.comp.networking.dpdk.devel/13447 or mlx5: http://thread.gmane.org/gmane.comp.networking.dpdk.devel/26986