From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Jingjing Wu <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] llib/ibrte_net: workaround to avoid macro conflict
Date: Tue, 30 Sep 2014 07:07:33 +0200 [thread overview]
Message-ID: <1916931.VRG6JyPOdY@xps13> (raw)
In-Reply-To: <1412045348-18543-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Hi Jingjing,
2014-09-30 10:49, Jingjing Wu:
> Macros such as IPPROTO_TCP, IPPROTO_UDP are already defined in <netinet/in.h>.
> If user's application includes <netinet/in.h> and rte_ip.h at the same time,
> there will be conflict error.
>
> This patch uses the way "#ifndef #endif" to avoid the conflict.
I still think it is not the good approach.
see http://dpdk.org/ml/archives/dev/2014-August/005006.html
and http://dpdk.org/ml/archives/dev/2014-August/005026.html
Why not simply remove these definitions?
--
Thomas
next prev parent reply other threads:[~2014-09-30 5:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 2:49 [PATCH] llib/ibrte_net: workaround to avoid macro conflict Jingjing Wu
[not found] ` <1412045348-18543-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-30 5:07 ` Thomas Monjalon [this message]
2014-10-09 5:17 ` Wu, Jingjing
2014-09-30 13:09 ` Neil Horman
[not found] ` <20140930130950.GF2193-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-09 5:20 ` Wu, Jingjing
[not found] ` <9BB6961774997848B5B42BEC655768F8B04B34-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-09 5:37 ` Matthew Hall
2014-10-09 11:29 ` Neil Horman
[not found] ` <20141009112918.GA20940-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-11-03 7:41 ` Thomas Monjalon
2014-11-17 14:17 ` Neil Horman
[not found] ` <20141117141708.GE17886-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-11-27 11:48 ` [PATCH] net: fix conflict with libc Thomas Monjalon
[not found] ` <1417088895-15568-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-27 14:03 ` Ivan Boule
[not found] ` <54772F35.302-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-27 18:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1916931.VRG6JyPOdY@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).