From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: mk: fix LDFLAGS for shared lib
Date: Thu, 11 Dec 2014 01:46:36 +0100
Message-ID: <1917406.222ZYZX27x@xps13>
References: <7F861DC0615E0C47A872E6F3C5FCDDBD05DCB8C6@BPXM14GP.gisp.nec.co.jp>
 <20141208150154.GA3907@localhost.localdomain>
 <7F861DC0615E0C47A872E6F3C5FCDDBD05DD32B1@BPXM14GP.gisp.nec.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org, Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
To: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD05DD32B1-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-12-08 23:44, Hiroshi Shimamoto:
> > On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote:
> > > From: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> > >
> > > Only CPU_LDFLAGS is used in mk/rte.sharelib.mk.
> > > It should be LDFLAGS to build the library with correct linkage options.
> > >
> > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> > > Reviewed-by: Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
> > >
> > > ---
> > > mk/rte.sharelib.mk | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk
> > > index c0a811a..df6c268 100644
> > > --- a/mk/rte.sharelib.mk
> > > +++ b/mk/rte.sharelib.mk
> > > @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE
> > >
> > >  OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o)
> > >
> > > -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> > > +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> > >  O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
> > >  O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)","  LD $(@)")
> > >  O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)"
> > 
> > Does this continue to work on cross compiled arches (32 bit on 64 bit systems
> > and vice versa)?  I have this recollection that something in CPU_LDFLAGS was
> > needed
> 
> yes, LDFLAGS must contain CPU_LDFLAGS.
> 
> mk/target/generic/rte.vars.mk:# merge all LDFLAGS
> mk/target/generic/rte.vars.mk:LDFLAGS := $(CPU_LDFLAGS) $(EXECENV_LDFLAGS) $(TOOLCHAIN_LDFLAGS) $(MACHINE_LDFLAGS)
> mk/target/generic/rte.vars.mk:LDFLAGS += $(TARGET_LDFLAGS)

Applied

Thanks
-- 
Thomas