From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 4/5] igb_uio: fix IRQ mode handling Date: Thu, 22 May 2014 15:50:58 +0200 Message-ID: <19189491.dUSBC7Ojvo@xps13> References: <20140514163401.079384157@networkplumber.org> <20140514163510.727992614@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org, Stephen Hemminger To: Stephen Hemminger Return-path: In-Reply-To: <20140514163510.727992614-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Stephen, 2014-05-14 09:34, Stephen Hemminger: > The igb_uio driver does not handle interrupt mode correctly. > It doesn't do the right thing and start with the most desired > mode and fall back to legacy modes as needed. I'm not sure to understand what you describe. > It also has a custom pci config lock was broken for any recent kernels. > Instead pci_intx functions that provide the needed access. I think some words are missing here. > VMWare PCI emulation of interrupts is particularly broken. > E1000 on VMWare doesn't work at all because INTX support > in ESX doesn't really work. The kernel pci_intx routines check > this and detect the failure. To handle this case fallback > to an even more legacy mode using irq enable/disable. Is it possible to split this patch for each issue? Thanks -- Thomas