From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 0/3] Coverity fixes for malloc Date: Fri, 27 Apr 2018 23:33:48 +0200 Message-ID: <1925231.7TIUCjMidO@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Anatoly Burakov Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 232356904 for ; Fri, 27 Apr 2018 23:33:51 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/04/2018 12:15, Anatoly Burakov: > This patchset fixes a few Coverity issues in malloc > introduced by recent DPDK memory hotplug patchset. > > Coverity issues fixed: > - 272566 - possible null dereference > - 272574 - use value before verification > > The following coverity issues were not fixed: > - 272573 - calling memset with size 0 > - This is intentional, size will not be 0 in malloc debug > - 272571 - negative return not handled > - False positive, proper API usage ensures no negative returns > - 272590 - negative return not handled > - Same as above > - 272597 - negative return not handled > - Same as above > > Also, replace all instaces of snprintf with strlcpy. > > v2: > - Dropped fixes for 272571, 272590, 272597 as false positives > > Anatoly Burakov (3): > malloc: replace snprintf with strlcpy > malloc: fix potential out-of-bounds array access > malloc: fix potential dereferencing of NULL pointer Applied, thanks