From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] app/testpmd: fix testpmd exit using ctrl+d Date: Tue, 24 Jul 2018 14:33:47 +0200 Message-ID: <1925999.Zqez9Xlb98@xps> References: <20180723104425.10090-1-jasvinder.singh@intel.com> <1876510.4y0gDTZx5Q@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bernard.iremonger@intel.com, reshma.pattan@intel.com, motih@mellanox.com, olivier.matz@6wind.com, cristian.dumitrescu@intel.com To: Jasvinder Singh Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 67B27235 for ; Tue, 24 Jul 2018 14:33:54 +0200 (CEST) In-Reply-To: <1876510.4y0gDTZx5Q@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Important note: testpmd is currently really broken. We cannot have a RC2 until it is fixed. 24/07/2018 13:25, Thomas Monjalon: > 23/07/2018 12:44, Jasvinder Singh: > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission character (EOT) > > on the empty command line. > > Please describe what is the issue and what is the cause. > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > > > Reported-by: Mordechay Haimovsky > > Signed-off-by: Jasvinder Singh > > --- > > app/test-pmd/cmdline.c | 10 ++++++---- > > lib/librte_cmdline/cmdline.c | 2 +- > > It is very suspicious to change the cmdline library. > If there is a bug in this library, it deserves a separate fix.