From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/4] ethdev: rename callbacks field to intr_cbs Date: Fri, 13 Feb 2015 17:52:01 +0100 Message-ID: <1927015.aErEKHGAj8@xps13> References: <1419266844-4848-1-git-send-email-bruce.richardson@intel.com> <1423841989-9090-2-git-send-email-john.mcnamara@intel.com> <4241109.JKBOKelqd6@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: John McNamara , bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <4241109.JKBOKelqd6@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-13 17:06, Thomas Monjalon: > 2015-02-13 15:39, John McNamara: > > From: Richardson, Bruce > > > > The callbacks member of the rte_eth_dev structure has been renamed > > to intr_cbs to make it clear that it refers to callbacks from NIC > > interrupts. This then allows us to add other types of callbacks to > > the structure without ambiguity. > > Yes, good. > Actually this callback is used only for link status interrupt, right? > In the patchset for interrupt mode, new callbacks are used, right? > Should we name this callback more precisely? More naming considerations: - The link status interrupt callback could be named link_intr_cb. - The Rx callback could be named post_rx_burst_cb - The Tx callback could be named pre_tx_burst_cb