From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: Headers files with BSD license in kernel Date: Wed, 10 Jun 2015 10:54:05 +0200 Message-ID: <1927342.Zb0Nrj3NUW@xps13> References: <20150609174057.GA4394@linux.intel.com> <20150609181528.0053039d@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Bernal Marin, Miguel" Return-path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id ADA235A9D for ; Wed, 10 Jun 2015 10:55:00 +0200 (CEST) Received: by wgv5 with SMTP id 5so30366707wgv.1 for ; Wed, 10 Jun 2015 01:55:00 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-10 01:20, Zhang, Helin: > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote: > > > > > Hi, > > > > > > > > > > I'm working on Clear Linux project, and when I was integrating > > > > > DPDK kernel modules to our kernel I found there are two headers > > > > > with BSD License > > > > > > > > > > rte_pci_dev_feature_defs.h > > > > > rte_pci_dev_features.h > > > > > > > > > > those are included in igb_uio module. > > > > > > > > > > Are those licenses correct? > > > > You can always escalate a BSD license to GPL, but the other way is not allowed. > > Ideally, the language on the file should make it clear that it is dual licensed. > > In an ideal world, igb_uio would go away, I am working on that. > > Yes, I agree with you. To be clearer, rte_pci_dev_feature_defs.h should be in dual > liceses, and rte_pci_dev_features.h should be in GPL license. Yes, it is an error from this commit: http://dpdk.org/browse/dpdk/commit/?id=88701645c98c9c88 These definitions were moved from a GPL file so they should keep the GPL header. Then it is used in EAL: http://dpdk.org/browse/dpdk/commit/?id=ff0b67d1c868c19 So it must be dual licensed, like for rte_pci_dev_ids.h: http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/rte_pci_dev_ids.h