From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] igb_uio: only check for pci bridge in
 supported by linux kernel
Date: Tue, 17 Apr 2018 14:33:46 +0100
Message-ID: <192d3804-6d73-71fc-eb77-df2378caade5@intel.com>
References: <e87d3f78-388d-592d-a127-3a11da480744@intel.com>
 <20180416205110.1354-1-ajit.khaparde@broadcom.com>
 <8CEF83825BEC744B83065625E567D7C24E0AE8B7@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Scott Branden <scott.branden@broadcom.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id D16C78E5D
 for <dev@dpdk.org>; Tue, 17 Apr 2018 15:33:49 +0200 (CEST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0AE8B7@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/17/2018 1:58 PM, Iremonger, Bernard wrote:
> Hi Scott, Ajit,
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ajit Khaparde
>> Sent: Monday, April 16, 2018 9:51 PM
>> To: dev@dpdk.org
>> Cc: Scott Branden <scott.branden@broadcom.com>
>> Subject: [dpdk-dev] [PATCH] igb_uio: only check for pci bridge in supported by
>> linux kernel
>>
>> From: Scott Branden <scott.branden@broadcom.com>
>>
>> Starting from Linux v3.16 pci_is_bridge() is in linux/pci.h,  in previous versions it
>> is in drivers/pci/pci.h which is private header.
>>
>> Fix build error when calling pci_is_bridge by not calling/supporting pci_is_bridge
>> with kernel versions before 3.16.
>>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>

<...>

> This patch fixes the compile error seen on the master branch.
> However there are the following checkpatch.pl  warnings:
> 
> WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged
> #40: FILE: kernel/linux/igb_uio/compat.h:136:
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 16, 0)

We need version check, so we can ignore this warning

> WARNING: Comparisons should place the constant on the right side of the test
> #40: FILE: kernel/linux/igb_uio/compat.h:136:
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 16, 0)

Other checks are also like this, I believe better to be compatible.

I think we can ignore both warnings for this case.

> 
> total: 0 errors, 2 warnings, 19 lines checked
> 
> Regards,
> 
> Bernard.
>  
>