From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] test/logs: fix dynamic log levels testing Date: Thu, 05 Oct 2017 23:19:35 +0200 Message-ID: <1930402.9rVUIpZKSN@xps> References: <1506019449-18782-1-git-send-email-radoslaw.biernacki@linaro.org> <20170925102531.zrk4cg75h55q6jvy@platinum> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Olivier MATZ To: Radoslaw Biernacki Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3516A1B1F9 for ; Thu, 5 Oct 2017 23:19:37 +0200 (CEST) In-Reply-To: <20170925102531.zrk4cg75h55q6jvy@platinum> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/09/2017 12:25, Olivier MATZ: > On Thu, Sep 21, 2017 at 08:44:09PM +0200, Radoslaw Biernacki wrote: > > This patch fixes the dynamic log levels testing in logs_autotest. > > Introduction of rte_log_set_level() in patch c1b5fa94a46f was done > > with parameter RTE_LOG_EMERG which caused all RTE_LOG() calls an > > early return due to all given levels were far below EMERG. > > If first two logs supposed to show up on console, the initial log > > level must be low (DEBUG). It is than changed above ERR when we test > > if TESTAPP2 log type can be filtered by log type log level. > > > > Fixes: c1b5fa94a46f ("eal: support dynamic log types") > > > > Signed-off-by: Radoslaw Biernacki > > Acked-by: Olivier Matz Applied, thanks