From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v1 04/10] app/test: support resources
	archived by tar
Date: Thu, 12 May 2016 17:26:26 +0200
Message-ID: <1930885.2DNqPEin9b@xps13>
References: <1462531720-26217-1-git-send-email-viktorin@rehivetech.com>
 <1462531720-26217-5-git-send-email-viktorin@rehivetech.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 David Marchand <david.marchand@6wind.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 0AB156CCF
 for <dev@dpdk.org>; Thu, 12 May 2016 17:26:28 +0200 (CEST)
Received: by mail-wm0-f52.google.com with SMTP id a17so142390792wme.0
 for <dev@dpdk.org>; Thu, 12 May 2016 08:26:28 -0700 (PDT)
In-Reply-To: <1462531720-26217-5-git-send-email-viktorin@rehivetech.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-06 12:48, Jan Viktorin:
> When needing a more complex resource (a file hierarchy), packing every single
> file as a single resource would be very ineffective. For that purpose, it is
> possible to pack the files into a tar archive, extract it before test from the
> resource and finally clean up all the created files.
> 
> This patch introduces functions resource_untar and resource_rm_by_tar to
> perform those tasks. An example of using those functions is included as a test.
> 
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> ---
>  app/test/Makefile        |   4 ++
>  app/test/resource.c      | 180 +++++++++++++++++++++++++++++++++++++++++++++++
>  app/test/resource.h      |  13 ++++
>  app/test/test_resource.c |  29 ++++++++
>  4 files changed, 226 insertions(+)
> 
> diff --git a/app/test/Makefile b/app/test/Makefile
> index a9502f1..90acd63 100644
> --- a/app/test/Makefile
> +++ b/app/test/Makefile
> @@ -77,6 +77,9 @@ SRCS-y += test.c
>  SRCS-y += resource.c
>  SRCS-y += test_resource.c
>  $(eval $(call resource,test_resource_c,resource.c))
> +$(eval $(call resource,test_resource_tar,resource.tar))

This tar resource is not provided. Should it be created in the Makefile?